Plamen5kov/fix get set null field #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 |
|
Why using UTF-8 when converting to Java string? I suggest you use this method. Also, consider adding a test, verifying this behavior. |
|
💚 |
dtopuzov
force-pushed
the
plamen5kov/fix_get_set_null_field
branch
from
8f8726b
to
3eb7aac
Compare
|
💔 |
|
💚 |
Plamen5kov
added a commit
that referenced
this pull request
Sep 15, 2015
…_field Plamen5kov/fix get set null field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #219