Skip to content

Switching to v8 causing crash [ui-image] #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keerl opened this issue Nov 13, 2020 · 8 comments
Closed

Switching to v8 causing crash [ui-image] #81

keerl opened this issue Nov 13, 2020 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@keerl
Copy link

keerl commented Nov 13, 2020

I am trying to get my app updated to use the iOS v8 runtime, but I am getting some bad crashes with virtually no errors in a few places.

The error stems from using the ui-image plugin. I have reported the issue there, but am adding it here as it seems to be specific to the v8 runtime and not the plugin as it works fine using tns-ios.

Here is a simple demo app that shows the problem: v8-crash-ui-image.zip

When the app loads, it will start loading images and if you start scrolling down the app will violently crash with no error. See attached GIF for demo of crash.

ezgif com-gif-maker

I have to go into the crash logs to even see what happened. Here is the error I am getting from there.

Screen Shot 2020-11-09 at 2 09 59 PM

@captainhaddockfr35
Copy link

Same problem here : lib nativescript-community/ui-image v4.0.11 and ns 7.0.10

@romandrahan
Copy link

romandrahan commented Nov 17, 2020

Same for me on the latest @nativescript/ios@7.0.6 and latest nativescript-community/ui-image@4.0.13 and latest SDWebImage ~> 5.9.5 pod.

Reproducible with ListView and RadListView.

Crash:

Project to reproduce: https://github.com/romandragan/ui-image-crash-radlistview

@keerl
Copy link
Author

keerl commented Nov 17, 2020

Here is the error from my crash with the demo project attached above.

Screen Shot 2020-11-17 at 7 28 51 AM

@farfromrefug
Copy link
Contributor

@NathanaelA @NathanWalker let me comment on this as i am the maintainer of the plugin. It really seems to be related with the v8 runtime. We dont see a crash on the classic runtime.
Could you run the example to see the crash through xcode?
I will try and search through the SdWebImage repo to see if that issue is reported there.

@darind darind self-assigned this Nov 17, 2020
@darind darind added the bug Something isn't working label Nov 17, 2020
@darind
Copy link
Collaborator

darind commented Nov 17, 2020

@keerl, thanks for the detailed report and sample app. A PR that should address this issue is on the way.

@farfromrefug
Copy link
Contributor

@darind damn you are fast ;)

@romandrahan
Copy link

Works fine with @nativescript/ios@7.0.6.

@keerl
Copy link
Author

keerl commented Nov 18, 2020

Works now. Thanks @darind !

@keerl keerl closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants