Skip to content

Not all modules from @nativescript/angular are exported to nativescript-angular #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mukaschultze opened this issue Nov 8, 2019 · 4 comments

Comments

@mukaschultze
Copy link

mukaschultze commented Nov 8, 2019

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

  • CLI: 6.2.0
  • Cross-platform modules: 6.2.0
  • Android Runtime: 6.2.0
  • iOS Runtime: 6.2.0
  • Plugin(s):
  • NativeScript-Angular: 8.20.1-rc-2019-11-08-175723-01
  • Angular: 8.2.0

Describe the bug

Modules like @nativescript/angular/app-host-view, @nativescript/angular/common/detached-loader, and @nativescript/angular/common/utils are not exported to nativescript-angular, this causes backwards incompatibility with some plugins.

To Reproduce

require("nativescript-angular/common/utils");

Causes the following error:

Module not found: Error: Can't resolve 'nativescript-angular/common/utils'

Expected behavior

nativescript-angular should export all modules from @nativescript/angular to keep backward compatibility.

Sample project

Additional context

@tbozhikov
Copy link
Contributor

Hi @mukaschultze, thanks for reporting this. We are preparing a patch addressing this breaking change. Meanwhile, could you please share the plugins you've found broken by this? Thanks!

@mukaschultze
Copy link
Author

@tbozhikov nativescript-material-bottomsheet is the only plugin I've found to be broken so far

@atchaiecommerce
Copy link

nativescript-masked-textfield is also broken. it looks for nativescript-angular/forms/value-accessors/text-value-accessor which is missing from nativescript-angular package.

@NickIliev
Copy link

The Jasmine import is also to be corrected.

The file zone-js/testing.jasmine.ts seems to point to the wrong location:

require("@nativescript/angular/dist/zone-nativescript.jasmine.js");

This should actually be @nativescript/angular/zone-js/dist/zone-nativescript.jasmine.js.

lini added a commit that referenced this issue Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants