Skip to content

feat: 8.7 updates #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 8, 2024
Merged

feat: 8.7 updates #231

merged 9 commits into from
Apr 8, 2024

Conversation

NathanWalker
Copy link
Contributor

8.7 updates with cleaner & simpler resource setups.

@cla-bot cla-bot bot added the cla: yes label Apr 3, 2024
@NathanWalker NathanWalker merged commit 03f7a78 into main Apr 8, 2024
1 of 23 checks passed
@NathanWalker NathanWalker deleted the feat/ns-8.7 branch April 8, 2024 16:25
@CatchABus
Copy link
Contributor

CatchABus commented Nov 6, 2024

@NathanWalker This PR has removed the following directories:

  • LaunchScreen.AspectFill.imageset
  • LaunchScreen.Center.imageset

These folders along with their file content are mandatory for CLI to generate splashes the traditional way because it won't do so if folders are missing.
We can either modify CLI or re-add those back.

UPDATED: I think LaunchScreen.storyboard would also need revert to its old state. Do we those new changes for new features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants