Fix Android builds when gradle args and project dir have spaces #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
requested review from
Mitko-Kerezov,
TsvetanMilanov and
petekanev
yyosifov
reviewed
Mar 24, 2017
| } | ||
|
|
||
| return this.$childProcess.spawnFromEvent(gradleBin, ["--stop", "--quiet"], "close", { stdio: "inherit", cwd: projectRoot }); | ||
| // TODO: Check if we have to pass compileSdk and other options here |
There was a problem hiding this comment.
can we help with this TODO?
There was a problem hiding this comment.
ping @Plamen5kov , @Pip3r4o for this
There was a problem hiding this comment.
I'm not sure why we need to call stop and should we pass other options...
There was a problem hiding this comment.
I've just tested it without args and it's working fine, so I'll remove the TODOD
TsvetanMilanov
approved these changes
Mar 24, 2017
yyosifov
reviewed
Mar 24, 2017
| @@ -504,6 +492,19 @@ export class AndroidProjectService extends projectServiceBaseLib.PlatformProject | |||
|
|
|||
| return versionInManifest; | |||
| } | |||
|
|
|||
| private async executeGradleCommand(projectRoot: string, gradleArgs: string[], childProcessOpts?: SpawnOptions, spawnFromEventOptions?: ISpawnFromEventOptions): Promise<ISpawnResult> { | |||
| const gradleBin = this.$hostInfo.isWindows ? "gradlew.bat" : "./gradlew"; | |||
There was a problem hiding this comment.
I would rename this const to "gradlew" as it points to the wrapper, not gradle itself.
yyosifov
approved these changes
Mar 24, 2017
In case you try building application, it will fail in case the following conditions are applied: * build on Windows * build for Android * build in release * path to project dir has spaces * path to certificate (keystore) has spaces OR the certificate(keystore) name itself has spaces OR the password has spaces The problem is in Node.js's `child_process` when `spawn` is used - on Windows it has issues when both the command (in our case this is the FULL PATH to gradlew.bat executable in platforms dir of the project) and ANY of the arguments passed to `child_process's spawn` have spaces. As we are also setting the current working directory of the spawned process to be the path to `<project dir>/platforms/android`, change the `command` passed to `spawn` to be just `gradlew`. This way we'll never have spaces in the command and we'll not hit this issue.
rosen-vladimirov
force-pushed
the
vladimirov/fix-android-spaces
branch
from
9dee3af to
e87415f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you try building application, it will fail in case the following conditions are applied:
The problem is in Node.js's
child_processwhenspawnis used - on Windows it has issues when both the command (in our case this is the FULL PATH to gradlew.bat executable in platforms dir of the project) and ANY of the arguments passed tochild_process's spawnhave spaces.As we are also setting the current working directory of the spawned process to be the path to
<project dir>/platforms/android, change thecommandpassed tospawnto be justgradlew. This way we'll never have spaces in the command and we'll not hit this issue.More information for the Node.js issue: nodejs/node-v0.x-archive#25895
There's a similar issue (linked in the comments of the above) for newer node.js versions. The suggested solution there is to use
{ shell: true}parameter tospawnmethod, but this will require handling of all spaces in the args on our own.