Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use more accurate PID detection on restart for android #5804

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

If you start the app through the launcher and the app is already open, we restart the logcat process and miss a few logs in the process. The current log line we're using to detect the start doesn't return the new PID at all and can conflict with apps with similar package names. This is a regression from #5755

What is the new behavior?

We accurately use a specific regex (/Start proc (?<pid>[0-9]+):(?<appId>.+?)\//) to find the exact appId and PID.

@cla-bot cla-bot bot added the cla: yes label Jun 26, 2024
@edusperoni edusperoni force-pushed the fix/correct-android-pid-detection branch from f32f86a to 1d1cc76 Compare June 26, 2024 19:59
@NathanWalker NathanWalker merged commit 6509773 into main Jul 1, 2024
1 check passed
@NathanWalker NathanWalker deleted the fix/correct-android-pid-detection branch July 1, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants