lib: replace chalk/ansi-colors/glob with Node.js built-ins #5853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports live reload. HMR is partial and works hand-in-hand with a hmr-client setup in the per-project @nativescript/vite setup.
Available since Node.js v22.0.0
Available since Node.js 20.17 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
|
Thank you @RafaelGSS we'll do some testing with the changes across production projects 💯 |
NathanWalker
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @NathanWalker this week, I'm opening this PR to replace some packages with Node.js built-in.
In the first commit, we are replacing
glob(node-glob) with the built-infs.promises.glob` that was added to Node.js 22.0.0. It's unlikely to backport this feature to Node.js 20.x as it's in maintenance mode.The second one replaced
chalkandansi-colorswithutil.styleText. This can be backported to all release lines as this is supported since Node.js 20.17.However, this doesn't suppress the
npm i -g nativescript@alphawarning as other dependencies rely on those packages. I suggest to re-do the package-lock.json after upgrading dependencies.