Skip to content

feat(watch): use before-watchPatterns hook #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mitko-Kerezov merged 1 commit into from
Feb 22, 2018
Merged

feat(watch): use before-watchPatterns hook #62

Mitko-Kerezov merged 1 commit into from
Feb 22, 2018

Conversation

@Mitko-Kerezov
Copy link
Contributor

@Mitko-Kerezov Mitko-Kerezov commented Feb 1, 2018

Use CLI's before-watchPatterns hook in order to instruct CLI not to watch .scss files.
In addition do not launch a sass watch process when bundling, assume bundler will handle it.

Ping @rosen-vladimirov

Merge after NativeScript/nativescript-cli#3350

@Mitko-Kerezov Mitko-Kerezov self-assigned this Feb 1, 2018
@Mitko-Kerezov Mitko-Kerezov force-pushed the kerezov/before-watchPatterns branch from f8a34b4 to d770fe5 Compare February 7, 2018 12:25
rosen-vladimirov
rosen-vladimirov approved these changes Feb 13, 2018
View reviewed changes
lib/watch.js Outdated
if (hookArgs.config) {
const appFilesUpdaterOptions = hookArgs.config.appFilesUpdaterOptions;
if (appFilesUpdaterOptions.bundle) {
logger.warn("Hook skipped because either bundling is in progress.")
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either what?

@rosen-vladimirov rosen-vladimirov mentioned this pull request Feb 13, 2018
Closed
@Mitko-Kerezov Mitko-Kerezov force-pushed the kerezov/before-watchPatterns branch from d770fe5 to 558b359 Compare February 15, 2018 12:49
@Mitko-Kerezov Mitko-Kerezov merged commit 9596d30 into master Feb 22, 2018
@farfromrefug
Copy link

farfromrefug commented Feb 28, 2018

Can't wait for this. Could you release a rc version with this?
Thanks

@Mitko-Kerezov Mitko-Kerezov deleted the kerezov/before-watchPatterns branch February 28, 2018 13:44
@radeva radeva mentioned this pull request Feb 28, 2018
Closed
@Mitko-Kerezov
Copy link
Contributor Author

Mitko-Kerezov commented Feb 28, 2018

@farfromrefug
We don't usually publish @next or @rc versions of the plugins. Instead, we are currently preparing a new version of this plugin and it should be released in the next few days.
In the meantime you can follow these steps in order to try the plugin out for yourself:
In a terminal, execute

  1. git clone https://github.com/NativeScript/nativescript-dev-sass
  2. cd nativescript-dev-sass/publish
  3. ./pack.sh

The pack script will produce a .tgz file, located in nativescript-dev-sass/publish/package which you can then use in a project by executing:
npm install --save-dev nativescript-dev-sass/publish/package/nativescript-dev-sass-1.3.5.tgz

Do bear in mind that this functionality will only be available if you use nativescript@next.

@farfromrefug
Copy link

farfromrefug commented Feb 28, 2018

@Mitko-Kerezov thanks. I totally understand. I will test it.
thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Mitko-Kerezov Mitko-Kerezov

Labels

feature new PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mitko-Kerezov @farfromrefug @rosen-vladimirov @radeva