Skip to content
This repository was archived by the owner on Nov 8, 2023. It is now read-only.

Conversation

Av1nag
Copy link

@Av1nag Av1nag commented Oct 10, 2023

The java docs are saying that

compile dependency is deprecated in gradle 7.0 and It was supressed by implementation dependency.

If the compile dependency is used the it is arising an error in nativescript-angular project while building android application using ns run android.

@cla-bot cla-bot bot added the cla: yes label Oct 10, 2023
@Av1nag Av1nag changed the title Update commit dep with implementation dep Update commit dependency with implementation dependency. Oct 10, 2023
@jakoguta
Copy link

jakoguta commented Nov 8, 2023

This needs to be merged.

@Av1nag
Copy link
Author

Av1nag commented Nov 8, 2023

This needs to be merged.

Thank you for recognizing ❤️

@NathanWalker
Copy link
Contributor

Hi @Av1nag and @jakoguta thank you for this. This update is published already in @nativescript/geolocation managed here:
https://github.com/NativeScript/plugins/blob/91d0b298ba00c42731346b2291e668c6bc43c66e/packages/geolocation/platforms/android/include.gradle#L15

We should probably archive this repo.

@Av1nag
Copy link
Author

Av1nag commented Nov 8, 2023

Hi @Av1nag and @jakoguta thank you for this. This update is published already in @nativescript/geolocation managed here:
https://github.com/NativeScript/plugins/blob/91d0b298ba00c42731346b2291e668c6bc43c66e/packages/geolocation/platforms/android/include.gradle#L15

We should probably archive this repo.

Okay @NathanWalker thank you for responding 🙌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants