Skip to content

Ability to define a custom hook name #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

jeremypele
Copy link
Contributor

I'm building a bunch of plugin and wanted to namespace them within my company name, the way @angular or @ngx does.

The issue I'm facing is that if I name my plugin @mycompany/core, @mycompany/core.js will not be a valid hook name (nesting issue) and breaks the installation.

I'm adding the ability to define a name property on the hook definition in package.json so we can overwrite the default package name if required. (ex: naming the hook: mycompany-core.js)

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@rosen-vladimirov
Copy link
Contributor

Hey @jeremypele ,
Thanks a lot for your contribution! It's an awesome idea! I'm merging this PR and we'll do our best to release a new version in the next few days.

@rosen-vladimirov rosen-vladimirov merged commit 9c3cbde into NativeScript:master Jan 29, 2019
@jeremypele
Copy link
Contributor Author

Thanks @rosen-vladimirov that was quick! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants