Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove un-needed tsc in demo scripts #178

Merged
merged 2 commits into from
Nov 1, 2019

Conversation

vakrilov
Copy link

@vakrilov vakrilov commented Nov 1, 2019

PR Checklist

What is the new behavior?

Remove unneeded npm run tsc when starting demo projects. Webpack builds the typescript.

@cla-bot cla-bot bot added the cla: yes label Nov 1, 2019
Copy link

@tgpetrov tgpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run tsc actually also makes npm i, which step I believe is still important

@vakrilov vakrilov requested a review from tgpetrov November 1, 2019 12:35
@tgpetrov tgpetrov merged commit dafc5c8 into master Nov 1, 2019
@tgpetrov tgpetrov deleted the remove-tsc-in-demo-scripts branch November 1, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants