fix: deps #18
Merged
fix: deps #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeva
suggested changes
Jul 10, 2017
src/package.json
Outdated
| "type": "git", | ||
| "url": "https://github.com/YourName/nativescript-yourplugin.git" | ||
| "demo.android": "npm i && npm run tsc && cd ../demo && tns run android --syncAllFiles", | ||
| "nuke": "rm -rf node_modules && cd ../demo && rm -rf hooks node_modules platforms" |
There was a problem hiding this comment.
Would mind to rename the command from "nuke" to "clean" or "clear"? I think it would be more meaningful for users. What's your opinion?
In addition, you can run npm run plugin.link in the nuke command so that the plugin is linked again in the demo after node_modules are deleted.
src/package.json
Outdated
| @@ -6,8 +6,8 @@ | |||
| "typings": "index.d.ts", | |||
| "nativescript": { | |||
| "platforms": { | |||
| "android": "3.0.0", | |||
| "ios": "3.0.0" | |||
| "android": "3.1.1", | |||
There was a problem hiding this comment.
In general this is the minimum required version of the runtime that will be able to process the plugin in the application. This means that setting runtime version to 3.1.1 here will make the plugin incompatible with 3.0 apps which shouldn't be a problem. That's why we prefer to have 3.0.0 here.
|
@radeva makes perfect sense! Updated now 👍 |
radeva
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ontypescriptdep which was installing2.4which causes problemsnpm run nukewas added to help users clear plugin and demo files for a fresh install when needed