-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch lint/isort/format to Ruff #105
Conversation
Ah, tests didn't run because I (thankfully) don't have access to your GitHub build secrets. I added a commit that changes the logic to read it from an environment variable if set, and skip hf_token -requiring tests otherwise. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 90.34% 90.34% -0.01%
==========================================
Files 33 33
Lines 4587 4586 -1
==========================================
- Hits 4144 4143 -1
Misses 443 443 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for these improvements.
Just found two fixes
Co-authored-by: Nathan Fradet <56734983+Natooz@users.noreply.github.com>
Thanks again for this PR! I will also follow the pytest formatting from miditoolkit here, along with hatch... Unless you want to take care of it, but I'm not asking anything here, you already did a lot! ❤️ |
As discussed in YatingMusic/miditoolkit#35.
More lint rules could be enabled later, this uses the most barebones default.