Fixing time signature preprocessing (time division mismatch) #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
In
_preprocess_time_signatures
, theticks_per_bar
computations were made based on the tokenizer's time division instead of the MIDI's, which can be different depending on the time signatures in the MIDI and those supported by the tokenizer, resulting in erroneously shifted time signatures.Now the MIDI's time signature is passed to
_preprocess_time_signatures
.📚 Documentation preview 📚: https://miditok--132.org.readthedocs.build/en/132/