-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of PyTorch data loading classes and methods #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 91.08% 91.24% +0.15%
==========================================
Files 33 34 +1
Lines 4994 5299 +305
==========================================
+ Hits 4549 4835 +286
- Misses 445 464 +19 ☔ View full report in Codecov by Sentry. |
…token_seq_len` methods
Natooz
force-pushed
the
pytorch-data-loading
branch
from
March 18, 2024 10:48
cbcd18d
to
1112266
Compare
…_note_density`, fixes `DatasetMIDI`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussions in #147, this PR implements a new PyTorch
Dataset
class, with the particularity of splitting the MIDI itself instead of splitting the tokens as done previously.📚 Documentation preview 📚: https://miditok--148.org.readthedocs.build/en/148/