Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of PyTorch data loading classes and methods #148

Merged
merged 28 commits into from
Mar 24, 2024
Merged

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Feb 21, 2024

Following the discussions in #147, this PR implements a new PyTorch Dataset class, with the particularity of splitting the MIDI itself instead of splitting the tokens as done previously.


📚 Documentation preview 📚: https://miditok--148.org.readthedocs.build/en/148/

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 92.96375% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 91.24%. Comparing base (408eec0) to head (48055b4).

Files Patch % Lines
miditok/pytorch_data/split_midi_utils.py 89.76% 13 Missing ⚠️
miditok/utils/utils.py 92.81% 11 Missing ⚠️
miditok/pytorch_data/datasets.py 92.63% 7 Missing ⚠️
tests/test_pytorch_data_loading.py 96.36% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   91.08%   91.24%   +0.15%     
==========================================
  Files          33       34       +1     
  Lines        4994     5299     +305     
==========================================
+ Hits         4549     4835     +286     
- Misses        445      464      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz marked this pull request as ready for review March 24, 2024 12:26
@Natooz Natooz merged commit c8050e6 into main Mar 24, 2024
14 checks passed
@Natooz Natooz deleted the pytorch-data-loading branch March 24, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant