Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update #175

Merged
merged 19 commits into from
Jun 4, 2024
Merged

Docs update #175

merged 19 commits into from
Jun 4, 2024

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Jun 2, 2024

split_files_for_training , split_score_per_note_density, get_average_num_tokens_per_note and split_dataset_to_subsequences methods moved from the "PyTorch_data" module to the "utils" module as it doesn't have to rely on PyTorch and should be able to be used with any DL framework.


📚 Documentation preview 📚: https://miditok--175.org.readthedocs.build/en/175/

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.53%. Comparing base (5b3c3f6) to head (e3da69e).
Report is 2 commits behind head on main.

Current head e3da69e differs from pull request most recent head 21ab591

Please upload reports for the commit 21ab591 to get more accurate results.

Files Patch % Lines
miditok/classes.py 75.86% 7 Missing ⚠️
miditok/pytorch_data/collators.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   90.46%   90.53%   +0.07%     
==========================================
  Files          35       35              
  Lines        5525     5527       +2     
==========================================
+ Hits         4998     5004       +6     
+ Misses        527      523       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz changed the title Docs update + Mypy Docs update Jun 3, 2024
…, making sure `preprocess_score` is 100% not inplace while optimizing copies
@Natooz Natooz marked this pull request as ready for review June 4, 2024 13:33
@Natooz Natooz merged commit 612d580 into main Jun 4, 2024
12 checks passed
@Natooz Natooz deleted the docs-update branch June 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant