-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PerTok Tokenizer #191
PerTok Tokenizer #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think from here we can take two paths:
- implement the basic micro-timing (without overlapping beat_res) in the
microtiming-draft
branch and make it work, then pull these changes to this branch and make the few adaptations, that shouldn't requite to change much things; - Put the
microtiming-draft
and MT feature aside from now and just focus onPerTok
, which would however need to fetch it's parameters solely fromconfig.additional_params
(for now) and undo thePerTok
-only changes made to the config andMusicTokenizer
classes.
In both cases we'll have to make the test pass.
For 1., I can take care of it (I don't know when, I'm quite busy for now, but hopefully this shouldn't take long, most of it is already implemented).
WDYT?
At this stage I would prefer to focus on the second option, as my experience has been that the duration/microtiming issue quickly becomes a rabbit-hole when it is implemented through the base classes. This would help get this update ready sooner and I do have to be conscious of time constraints here. One other question I have: Would it be okay for me to add something like "use_full_resolution" to the TokenizerConfig, in addition to "use_microtiming"? |
Noted, let’s focus on the second one then! For ‘use_full_resolution’, as long as it can be implemented only in PerTok that’s possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a few lint suggestions for the main files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint fixes in suggestions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 90.65% 90.15% -0.50%
==========================================
Files 40 41 +1
Lines 6011 6575 +564
==========================================
+ Hits 5449 5928 +479
- Misses 562 647 +85 ☔ View full report in Codecov by Sentry. |
This is Lemonaide's new Tokenizer, called PerTok (performance tokenizer)
📚 Documentation preview 📚: https://miditok--191.org.readthedocs.build/en/191/