Ms3744 patch tokenize dataset #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of the function does not work well with midi paths with directories with them in python notebooks, this is because a directory has to created before a file can be stored. For example, if the midi path is "a/b/c.mid", and the output directory is "d/e" then the code gives an error unless "d/e/a/b/" directory exists. This code will automatically take the name of the MIDI file and saves it in the directory as "d/e/c.json". There is a commented code in line 239 if we want to concatenate the entire path as "d/e/a/b/c.mid.json"
|
Hello Megha, thanks for this fix ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the function does not work well with midi paths with directories with them in python notebooks, this is because a directory has to created before a file can be stored. For example, if the midi path is
a/b/c.mid, and the output directory isd/ethen the code gives an error unlessd/e/a/b/directory exists.This PR will automatically take the name of the MIDI file and saves it in the directory as
d/e/c.json. There is a commented code in line 239 if we want to concatenate the entire path asd/e/a/b/c.mid.json