Cleaning up error in tokenize_midi_dataset #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match the midi_to_tokens function as per the latest release
Cleaning up the file save for tokenizing dataset
|
Hello Megha, thanks again for this fix ! 0.1.5 tested and released with the fix ! Best, |
|
And last bugfix 222b099 btw, v0.1.6 released on pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the midi_to_tokens function as per the latest release. I did not notice it the first time, but there's been a change made to the midi_to_tokens function, so this impacts the tokenize_midi_dataset function. I did not find midi_to_tokens used anywhere else though, so the impact is limited to this. Hope this is helpful. Thanks!