-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to delete equal successive tempo / time sig changes #66
Conversation
…ng pytest with xdist
Still changes to do towards Octuple and CPWord, in order to robustly test their tempo and time signature encoding / decoding. |
After analyzing 5k MMD files + the Maestro + POP909 datasets, here is the count of Time signatures :
At the end, I printed the TS which represent at least 0.5% of all TSs. I resorted to keep these values for now. Should we add some more ? |
These seem to be the most common ones. I can also refer to the time signature analysis of Lakh MIDI Dataset. Maybe adding 2/2, 9/8, 5/8, and 7/8 will make a nearly complete list. |
…moved, CPWord handling Time Signature, fixes in tempo and time sig decoding for MIDILike & REMI & TSD when one_token_stream is False, common TIME_SIGNATURE_RANGE set in constants, fixes in tests than now also test all time signature and tempo changes
When preprocessing a MIDI files, the previous version automatically deleted the successive tempo changes and time signature changes that had the same value.
Although this can make sense and reduce the nb of tokens, it can also reduce the recurrence of this information in sequences of tokens, where an user could on the other hand want to repeat it at recurrent intervals, especially with tokenizations such as TSD or MIDILike.
This option allows to decide wether or not to delete these identical successive changes.