Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing time signature encoding/decoding #76

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Fixing time signature encoding/decoding #76

merged 5 commits into from
Sep 28, 2023

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Sep 27, 2023

This PR fixes a bug on the encoding and decoding or TimeSignature tokens, especially for Bar/Position-based tokenizers. (#74)
REMI, CPWord, Octuple and MMM are affected.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (bd408a9) 89.68% compared to head (8b20a28) 90.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   89.68%   90.23%   +0.55%     
==========================================
  Files          31       31              
  Lines        4275     4303      +28     
==========================================
+ Hits         3834     3883      +49     
+ Misses        441      420      -21     
Files Coverage Δ
miditok/midi_tokenizer.py 90.40% <100.00%> (+1.33%) ⬆️
miditok/tokenizations/midi_like.py 94.40% <100.00%> (+0.65%) ⬆️
miditok/tokenizations/mmm.py 95.16% <100.00%> (+2.82%) ⬆️
miditok/tokenizations/tsd.py 98.29% <100.00%> (+0.85%) ⬆️
tests/test_bpe.py 90.10% <ø> (ø)
tests/test_io_formats.py 90.32% <100.00%> (+0.32%) ⬆️
tests/test_multitrack.py 84.12% <100.00%> (+0.52%) ⬆️
tests/test_saving_loading_config.py 92.00% <ø> (ø)
miditok/tokenizations/cp_word.py 94.91% <95.74%> (+1.63%) ⬆️
miditok/tokenizations/remi.py 96.64% <94.87%> (+1.66%) ⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz marked this pull request as ready for review September 28, 2023 06:50
@Natooz Natooz merged commit e01d849 into main Sep 28, 2023
14 checks passed
@Natooz Natooz deleted the fix-time-sig-barpos branch September 28, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant