Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing multi-stream decoding with several identical programs #81

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Oct 8, 2023

Following #74, this PR now handles multi-stream decoding with several identical programs (for all tokenizers).
Previously, identical programs resulted in merged tracks.

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (01cdac0) 90.29% compared to head (b1a37dc) 90.25%.
Report is 1 commits behind head on main.

❗ Current head b1a37dc differs from pull request most recent head 9ef5c23. Consider uploading reports for the commit 9ef5c23 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   90.29%   90.25%   -0.04%     
==========================================
  Files          31       31              
  Lines        4305     4425     +120     
==========================================
+ Hits         3887     3994     +107     
- Misses        418      431      +13     
Files Coverage Δ
miditok/midi_tokenizer.py 90.51% <100.00%> (-0.12%) ⬇️
miditok/tokenizations/structured.py 97.03% <100.00%> (+0.26%) ⬆️
tests/tests_utils.py 77.01% <50.00%> (-0.34%) ⬇️
miditok/tokenizations/cp_word.py 95.07% <96.49%> (+0.16%) ⬆️
miditok/tokenizations/tsd.py 97.99% <93.75%> (-0.30%) ⬇️
tests/test_one_track.py 79.16% <75.00%> (+1.89%) ⬆️
miditok/tokenizations/octuple.py 87.93% <84.00%> (+0.70%) ⬆️
miditok/tokenizations/remi.py 95.93% <90.90%> (-0.71%) ⬇️
miditok/tokenizations/midi_like.py 92.96% <78.57%> (-1.45%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz marked this pull request as ready for review October 10, 2023 15:34
@Natooz Natooz merged commit a7b3524 into main Oct 10, 2023
@Natooz Natooz deleted the fix-multi-stream-decoding branch October 12, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant