Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in DataCollator for classification labels #83

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Oct 12, 2023

Following #80, this PR fixes a bug in DataCollator when handling classification labels (tensors with 0 dimensions).

@leleogere

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a2d3ca8) 90.39% compared to head (81a6127) 90.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   90.39%   90.49%   +0.10%     
==========================================
  Files          31       31              
  Lines        4457     4463       +6     
==========================================
+ Hits         4029     4039      +10     
+ Misses        428      424       -4     
Files Coverage Δ
tests/test_pytorch_data_loading.py 90.58% <100.00%> (+3.84%) ⬆️
miditok/pytorch_data/collators.py 93.15% <88.88%> (+1.84%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz merged commit ed0d500 into main Oct 12, 2023
0 of 12 checks passed
@Natooz Natooz deleted the dataset-tok-labels branch October 12, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant