Add indent instructions #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
force-pushed
the
add_indent_instructions
branch
2 times, most recently
from
39154a3
to
ce0aafc
Compare
gassmoeller
force-pushed
the
add_indent_instructions
branch
from
ce0aafc
to
cc5c7a9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have several people working on the code it would be useful to have a unified style for indentation and brackets. I have some experience with the program
astyle(http://astyle.sourceforge.net/), which was build for exactly this purpose. It can run over c++ source and header files and unify indentation and where to put brackets and fix spacing. Unfortunately, I can not exactly reproduce the style of FDPS SPH so far. In particular the indentation ofpublic:/private:is slightly different, and there is an additional space before opening braces. Is this still something that could be useful? It already found a number of places where we accidentally used wrong indentation.