Skip to content

Commit

Permalink
feat(eslint): expiring-todo-comments to produce a warning instead of …
Browse files Browse the repository at this point in the history
…error
  • Loading branch information
kirillgroshkov committed Oct 12, 2024
1 parent 424c4a1 commit b717cce
Show file tree
Hide file tree
Showing 4 changed files with 150 additions and 132 deletions.
1 change: 1 addition & 0 deletions cfg/eslint-rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ module.exports = {
'unicorn/prefer-regexp-test': 0,
'unicorn/prefer-query-selector': 0,
'unicorn/prefer-prototype-methods': 0, // false-positive on node promisify() of callback functions
'unicorn/expiring-todo-comments': 1, // warning, instead of error
'@typescript-eslint/return-await': [2, 'always'],
'@typescript-eslint/require-await': 0,
'@typescript-eslint/no-misused-promises': 0,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"tsn-debug": "tsn testScript.ts",
"dev-lib": "tsn ./src/bin/dev-lib.ts",
"bt": "tsn ./src/bin/dev-lib.ts bt && tsn eslintPrintConfig",
"lbt": "tsn ./src/bin/dev-lib.ts lbt",
"lbt": "tsn ./src/bin/dev-lib.ts lbt && tsn eslintPrintConfig",
"build": "tsn ./src/bin/dev-lib.ts build",
"build-prod-esm-cjs": "tsn ./src/bin/dev-lib.ts build-esm-cjs",
"test": "tsn ./src/bin/dev-lib.ts test",
Expand Down
8 changes: 4 additions & 4 deletions src/test/cfg/eslint.config.dump.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"0": ".vue",
"1": ".html"
},
"parser": "typescript-eslint/parser@8.8.0",
"parser": "typescript-eslint/parser@8.8.1",
"project": "tsconfig.json"
},
"sourceType": "module"
Expand All @@ -18,9 +18,9 @@
},
"plugins": [
"@",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.8.0",
"@typescript-eslint:@typescript-eslint/eslint-plugin@8.8.1",
"unicorn:eslint-plugin-unicorn@56.0.0",
"vue:eslint-plugin-vue@9.28.0",
"vue:eslint-plugin-vue@9.29.0",
"import-x",
"simple-import-sort:eslint-plugin-simple-import-sort@12.1.1",
"jsdoc",
Expand Down Expand Up @@ -1320,7 +1320,7 @@
2
],
"unicorn/expiring-todo-comments": [
2
1
],
"unicorn/explicit-length-check": [
0
Expand Down
Loading

0 comments on commit b717cce

Please sign in to comment.