Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): add updateByQuery #14

Merged
merged 2 commits into from
May 24, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions src/mysql.db.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Readable, Transform } from 'node:stream'
import { promisify } from 'node:util'
import { DBPatch } from '@naturalcycles/db-lib'
import {
BaseCommonDB,
CommonDB,
Expand All @@ -15,6 +16,7 @@ import {
_mapKeys,
_mapValues,
_Memo,
_omit,
AnyObjectWithId,
CommonLogger,
commonLoggerPrefix,
Expand All @@ -34,7 +36,7 @@ import {
TypeCast,
} from 'mysql'
import * as mysql from 'mysql'
import { dbQueryToSQLDelete, dbQueryToSQLSelect, insertSQL } from './query.util'
import { dbQueryToSQLDelete, dbQueryToSQLSelect, dbQueryToSQLUpdate, insertSQL } from './query.util'
import {
jsonSchemaToMySQLDDL,
mapNameFromMySQL,
Expand Down Expand Up @@ -306,7 +308,7 @@ export class MysqlDB extends BaseCommonDB implements CommonDB {

const verb = opt.saveMethod === 'insert' ? 'INSERT' : 'REPLACE'

if (opt.assignGeneratedIds) {
if (opt.assignGeneratedIds && opt.saveMethod !== 'update') {
// Insert rows one-by-one, to get their auto-generated id

let i = -1
Expand All @@ -323,10 +325,18 @@ export class MysqlDB extends BaseCommonDB implements CommonDB {
}

// inserts are split into multiple sentenses to respect the max_packet_size (1Mb usually)
const sqls = insertSQL(table, rows, verb, this.cfg.logger)
if (opt.saveMethod === 'update') {
for await (const row of rows) {
_assert(row.id, 'Cannot update without providing an id')
const query = new DBQuery(table).filterEq('id', row.id)
await this.updateByQuery(query, _omit(row, ['id']))
}
} else {
const sqls = insertSQL(table, rows, verb, this.cfg.logger)

for await (const sql of sqls) {
await this.runSQL({ sql })
for await (const sql of sqls) {
await this.runSQL({ sql })
}
}
}

Expand Down Expand Up @@ -393,4 +403,15 @@ export class MysqlDB extends BaseCommonDB implements CommonDB {

return mysqlTableStatsToJsonSchemaField<ROW>(table, stats, this.cfg.logger)
}

override async updateByQuery<ROW extends ObjectWithId>(
q: DBQuery<ROW>,
patch: DBPatch<ROW>,
): Promise<number> {
const sql = dbQueryToSQLUpdate(q, patch)
if (!sql) return 0

const { affectedRows } = await this.runSQL<OkPacket>({ sql })
return affectedRows
}
}