Skip to content

Commit

Permalink
Add ARIA labels + missing header
Browse files Browse the repository at this point in the history
original: b62e984, 0af956d
  • Loading branch information
alycejenni committed Nov 17, 2022
1 parent c6050cb commit 2b02737
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 6 deletions.
14 changes: 11 additions & 3 deletions ckan/templates/group/members.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ <h3 class="page-heading">{{ _('{0} members'.format(members|length)) }}</h3>
<tr>
<th>{{ _('User') }}</th>
<th>{{ _('Role') }}</th>
<th></th>
<th>{{ _('Actions') }}</th>
</tr>
</thead>
<tbody>
Expand All @@ -25,10 +25,18 @@ <h3 class="page-heading">{{ _('{0} members'.format(members|length)) }}</h3>
<td>{{ role }}</td>
<td>
<div class="btn-group pull-right">
<a class="btn btn-default btn-sm" href="{{ h.url_for(group_type + '.member_new', id=group_dict.id, user=user_id) }}" title="{{ _('Edit') }}">
<a class="btn btn-default btn-sm"
href="{{ h.url_for(group_type + '.member_new', id=group_dict.id, user=user_id) }}"
title="{{ _('Edit') }}" aria-label="Edit member">
<i class="fa fa-wrench"></i>
</a>
<a class="btn btn-danger btn-sm" href="{{ h.url_for(group_type + '.member_delete', id=group_dict.id, user=user_id) }}" data-module="confirm-action" data-module-content="{{ _('Are you sure you want to delete this member?') }}" title="{{ _('Delete') }}">{% block delete_button_text %}<i class="fa fa-times"></i>{% endblock %}</a>
<a class="btn btn-danger btn-sm"
href="{{ h.url_for(group_type + '.member_delete', id=group_dict.id, user=user_id) }}"
data-module="confirm-action"
data-module-content="{{ _('Are you sure you want to delete this member?') }}"
title="{{ _('Delete') }}" aria-label="Delete member">
{% block delete_button_text %}<i class="fa fa-times"></i>{% endblock %}
</a>
</div>
</td>
</tr>
Expand Down
14 changes: 11 additions & 3 deletions ckan/templates/organization/members.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ <h3 class="page-heading">{{ members_count }}</h3>
<tr>
<th>{{ _('User') }}</th>
<th>{{ _('Role') }}</th>
<th></th>
<th>{{ _('Actions') }}</th>
</tr>
</thead>
<tbody>
Expand All @@ -30,10 +30,18 @@ <h3 class="page-heading">{{ members_count }}</h3>
<td>{{ role }}</td>
<td>
<div class="btn-group pull-right">
<a class="btn btn-default btn-sm" href="{{ h.url_for(group_type + '.member_new', id=group_dict.id, user=user_id) }}" title="{{ _('Edit') }}">
<a class="btn btn-default btn-sm"
href="{{ h.url_for(group_type + '.member_new', id=group_dict.id, user=user_id) }}"
title="{{ _('Edit') }}" aria-label="Edit member">
<i class="fa fa-wrench"></i>
</a>
<a class="btn btn-danger btn-sm" href="{{ h.url_for(group_type + '.member_delete', id=group_dict.id, user=user_id) }}" data-module="confirm-action" data-module-content="{{ _('Are you sure you want to delete this member?') }}" title="{{ _('Delete') }}">{% block delete_button_text %}<i class="fa fa-times"></i>{% endblock %}</a>
<a class="btn btn-danger btn-sm"
href="{{ h.url_for(group_type + '.member_delete', id=group_dict.id, user=user_id) }}"
data-module="confirm-action"
data-module-content="{{ _('Are you sure you want to delete this member?') }}"
title="{{ _('Delete') }}" aria-label="Delete member">
{% block delete_button_text %}<i class="fa fa-times"></i>{% endblock %}
</a>
</div>
</td>
</tr>
Expand Down

0 comments on commit 2b02737

Please sign in to comment.