Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/367 reveal file #381

Merged
merged 2 commits into from
Nov 14, 2016
Merged

Feature/367 reveal file #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39084d5
[#367] fix reveal file for Windows
quicklizard99 Oct 25, 2016
5c012c4
[#367] correct commit for fixing reveal file for Windows
quicklizard99 Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ This is an overview of major changes. Refer to the git repository for a full log

Version 0.1.35
-------------
- #367 Reveal file doesn't work on Windows
- #273 Inselect as a package
- #83 Architecture and code organisation

Expand Down
2 changes: 1 addition & 1 deletion inselect/gui/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def reveal_path(path):
# http://stackoverflow.com/a/3546503
path = path.resolve()
if sys.platform.startswith("win"):
res = subprocess.call(["explorer.exe", u"/select,{0}".format(path)])
res = subprocess.call(u"explorer.exe /select,{0}".format(path))
if 1 != res:
raise ValueError('Unexpected exit code [{0}]'.format(res))
elif 'Darwin' == platform.system():
Expand Down