Ignore empty strings in URL column on import #6075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the url is an empty string then the
MediaFeedsInternetProvider
will throw aMediaInternetNoHandlerException
because it can't find a handler for it. Presumably, this is desired under normal circumstances, but during an import the cell's values are empty strings so this error is thrown all the time. Therefore, preempt it before it happens!I fixed it like this rather than patching the
MediaFeedsInternetProvider
itself under the assumption that other code is expecting it to throwMediaInternetNoHandlerException
exceptions when it encountersinvalid strings, like the empty string. Does feel a bit hacky though.
#6062