Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porter stemmer not stemming properly #176

Closed
wooorm opened this issue Jul 22, 2014 · 8 comments
Closed

Porter stemmer not stemming properly #176

wooorm opened this issue Jul 22, 2014 · 8 comments
Assignees
Labels

Comments

@wooorm
Copy link

wooorm commented Jul 22, 2014

Out of 23532 input/outputs provided with the original algorithm, Natural fails on 558 cases (Natural@0.1.28).

Failures include:

  • ace to ac;
  • acknowledg to acknowledg;
  • adoptedly to adoptedli;
  • aedile to aedil;

Source: See http://tartarus.org/martin/PorterStemmer/, and search for "To test the programs out".

@kkoch986 kkoch986 added the Bugs label Jul 22, 2014
@kkoch986
Copy link
Member

Correct me if i'm wrong but acknowledg to acknowledg are the same

@wooorm
Copy link
Author

wooorm commented Jul 22, 2014

You seem to be right 👍. Weird why that error’d in my tests. Let me check out.

@wooorm
Copy link
Author

wooorm commented Jul 22, 2014

EDIT: Hold on. My above examples do not include the actual output Natural gave, but rather what it should give. Here are the actual return values:

> n.PorterStemmer.stem('ace')
'ace'
> n.PorterStemmer.stem('acknowledg')
'acknowlg'
> n.PorterStemmer.stem('adoptedly')
'adoptli'
> n.PorterStemmer.stem('aedile')
'ail'

@kkoch986
Copy link
Member

I see, ill try to go over the porter stemmer in more detail ASAP. Thanks!

@chrisumbel
Copy link
Member

Didn't mean to close. I've handled the cases mentioned initially, but more remain. Will be addressing.

156 cases remain.

@chrisumbel chrisumbel reopened this Mar 8, 2015
chrisumbel added a commit that referenced this issue Mar 8, 2015
chrisumbel added a commit that referenced this issue Mar 14, 2015
chrisumbel added a commit that referenced this issue Mar 14, 2015
chrisumbel added a commit that referenced this issue Mar 14, 2015
chrisumbel added a commit that referenced this issue Mar 14, 2015
chrisumbel added a commit that referenced this issue Mar 14, 2015
chrisumbel added a commit that referenced this issue Mar 14, 2015
@pranavatgithub
Copy link

Still bugs with PorterStemmer.Anyone working on it??
please check the examples

  1. natural.PorterStemmer.stem("recharged") ---->> recharg
    2.natural.PorterStemmer.stem("subscribed") ----->> subscrib
    3.natural.PorterStemmer.stem("restored") ------->>restor

@pranavatgithub
Copy link

@kkoch986
Copy link
Member

kkoch986 commented Jul 7, 2017

assuming whats at the end of those arrows is the output from natural i think those are correct. i verified with another unrelated implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants