Issue with snapshot tagging in Step-2

[requaos]

To my understanding these are now 'annotated' tags, which reference a hash with info which refers to another hash of the actual commit. So I read that this error is just seeing this, but why doesn't it know what to do with these? I may also be missing something:

Failed to tag mkstream 3993. Tag points to cb83d88e9325041f8ebd95680da13590be055f6b instead of 45af6d0e408cb7baecbd065a086935e6cc7fb44b
mkstream 3993. Tag rw_12.0.0.7 exists, re-creating on rw_qa_int at 45af6d0e
Failed to tag mkstream 3993. Tag points to cb83d88e9325041f8ebd95680da13590be055f6b instead of 45af6d0e408cb7baecbd065a086935e6cc7fb44b
Running time was  0:16:34.25
The script has encountered an exception, aborting!
Traceback (most recent call last):
  File "/db/neil/ac2git/ac2git.py", line 4075, in AccuRev2GitMain
    rv = state.Start(isRestart=args.restart, isSoftRestart=args.softRestart)
  File "/db/neil/ac2git/ac2git.py", line 3347, in Start
    self.ProcessTransactions()
  File "/db/neil/ac2git/ac2git.py", line 3123, in ProcessTransactions
    self.ProcessTransaction(streamMap=state["stream_map"], trId=tr, affectedStreamMap=transactionsMap[tr], prevAffectedStreamMap=prevAffectedStreamMap)
  File "/db/neil/ac2git/ac2git.py", line 2721, in ProcessTransaction
    raise Exception("Failed to create tag {branch} at {hash} (latest commit on {parentBranch}).".format(branch=branchName, hash=self.ShortHash(basisCommitHash), parentBranch=basisBranchName))
Exception: Failed to create tag rw_12.0.0.7 at 45af6d0e (latest commit on rw_qa_int).
Traceback (most recent call last):
  File "/db/neil/ac2git/ac2git.py", line 4095, in <module>
    AccuRev2GitMain(sys.argv)
  File "/db/neil/ac2git/ac2git.py", line 4075, in AccuRev2GitMain
    rv = state.Start(isRestart=args.restart, isSoftRestart=args.softRestart)
  File "/db/neil/ac2git/ac2git.py", line 3347, in Start
    self.ProcessTransactions()
  File "/db/neil/ac2git/ac2git.py", line 3123, in ProcessTransactions
    self.ProcessTransaction(streamMap=state["stream_map"], trId=tr, affectedStreamMap=transactionsMap[tr], prevAffectedStreamMap=prevAffectedStreamMap)
  File "/db/neil/ac2git/ac2git.py", line 2721, in ProcessTransaction
    raise Exception("Failed to create tag {branch} at {hash} (latest commit on {parentBranch}).".format(branch=branchName, hash=self.ShortHash(basisCommitHash), parentBranch=basisBranchName))
Exception: Failed to create tag rw_12.0.0.7 at 45af6d0e (latest commit on rw_qa_int).

Hoping it is something simple

[orao]

Searching through the code for the error message led me to the comments here which agree with your analysis.

A check could be added if the commitHash != objectHash to further check if the type of object is a tag, probably using something like git cat-file, and only failing if the actual commit is different. Or something along those lines.

However, I no longer have access to AccuRev and cannot validate any changes to this code so I will have to leave it to those using it to try and make the fix.

[orao]

If you are able to help fix this, pull requests are welcome.

[requaos]

I also no longer have access to accurev. I was successful in my task, however, I omitted the snapshot streams to accomplish that.

…

On Wed, Apr 17, 2019, 6:39 AM Lazar Šumar ***@***.***> wrote: If you are able to help fix this, pull requests are welcome. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#116 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANlVUmQvAyITmFD-9kLybkX9xfUlHRuSks5vhvnagaJpZM4Tqz7Z> .

[orao]

Thanks for letting us know. I will leave this issue open as it might affect someone else in the future. I'm glad you were successful :)