Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default sorting and style attribute #173

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

default sorting and style attribute #173

wants to merge 6 commits into from

Conversation

iamkallolpratim
Copy link

No description provided.

@Nayjest
Copy link
Owner

Nayjest commented May 24, 2017 •
edited
Loading

Hi!

  1. GridConfig now has two getPageSize() methods.
  2. There is no protected $defaultSort property and no use-cases for getDefaultSort() (it should be used in some way in code if it's added there).
  3. What is reason for replacing .btn-default to .btn-secondary?
  4. Please create separate pull requests for separate features, it will significantly increase chances of success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamkallolpratim @Nayjest