Bit Operators #32
Bit Operators #32
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 81.52% 81.03% -0.50%
==========================================
Files 105 105
Lines 16920 17025 +105
Branches 6107 6132 +25
==========================================
+ Hits 13794 13796 +2
- Misses 3063 3166 +103
Partials 63 63
Continue to review full report in Codecov by Sentry.
|
|
Thanks a lot for your contribution! SPIR-V support should be pretty easy to add, and unit tests should be added too to test the generation (instead of changing the sfml example). I'll look more deeply into your contribution once I have more time. |
|
There was a problem hiding this comment.
This seems great overall, however two things are lacking:
- vectors of i32/u32 support (they do support bitwise operation on a per-component basis)
- unit tests
If you don't have time or are not willing to improve this PR I'll merge it in a branch and do it myself, but I won't have time before a few days.
Thank you for your contribution.
| BinaryOr = 14, //< | | ||
| BinaryXor = 15, //< ~ | ||
| LeftShift = 16, //< << | ||
| RightShift = 17, //< >> |
There was a problem hiding this comment.
Please sort the enum by alphabetical order
* Added the tokens * Implementation of binary xor, or and and * implementation of binary not * revert the mandelbrot example * Add spirv emisson * added suport for shift operators * Added constanted propagation for the bit operators
This is an implementation of issue #8. It still doesnt have yet the multiply/division optimization, the constatant propagation nor the spir-v emission.