-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved the scripts used for example and doc building to xtask #321
Conversation
Hey! I was out for a few days (Spain holidays), let me settle and I'll come back to this in a few days! thanks! |
This is pretty nice, I love the Something that I saw is that if you don't have |
Hmm 🤔 For me, when i execute Can you check which output gives to you the value in
About checking if some of the tools are available when trying to compile, thats something I can totally do. P.S: I took the decision to move everything related to examples from ``./docs/HERE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @Rzial, sorry for the delay (once again). The I hope this is fine with you. Thanks you so much for allocating the time and the effort to make this! |
This PR handles #319 and allows to handle cross-platform compilation without major overhead in terms of script maintenance.
For now I've only added the building scripts but we may add the others in the future:
I've tested Windows on MSVC and Web targets and it works pretty fine. Seems the same for Linux but I would like some external confirmation since is not my main dev scene for Notan and I might had some overlook.
P.S.: This is one of my firsts Rust code contributions so there may be some flaws in codewritting/codestyle. If there is any feedback I'm open to it 😄