Feat: allow withdraw by users directly #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the spirit of being able to eventually remove all connector functionality from the Engine contract, we need a method to be able to Withdraw tokens that can be called by users directly. This PR renames the
withdraw
function toengine_withdraw
as it can only be called by Engine instances, and adds a newwithdraw
function where the sender is not passed as an argument, but instead is determined from thepredecessor_account_id
. Since the sender is no longer specified by the user thewithdraw
function no longer needs to be protected; it can be called by any user.Note aurora-is-near/aurora-engine#607 will need to be updated to call
engine_withdraw
instead of justwithdraw
.Testing
New test for the
engine_withdraw
function. Existing tests for the permissionlesswithdraw
function.