-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build!: update Rust version and near-*
dependencies
#118
Conversation
near-*
dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please verify that it is still possible to build contracts with plugins using rust 1.69, because currently there is an issue with parsing the contracts by nearblocks if the rust version is 1.70 and higher.
Check this: https://github.com/aurora-is-near/rainbow-token-connector/pull/234/files
and this
near/nearcore#9143 (comment)
@karim-en thank you for bringing this up. As you were running into the same issue, I tried to figure out the underlying problem. See this issue. To verify |
Turns out that the failure to build As a result, the MSRV can be lowered to 1.69.0, which is used to compile test contracts and in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This explicit downgrading of dependencies is a little awkward so if possible I think it would be nice to get the MSRV up to 1.70 (once this is possible for the bridge). But for now this looks like a good work-around.
Actually, the contracts that are built with 1.70 work correctly because the protocol itself has already been upgraded to support those contracts. |
I've opened #121 for the MSRV upgrade. |
With the current minimum
rust-version
of 1.64.0 tests cannot be built anymore, e.g. see this CI failure. Hence this PR increseasesrust-version
to1.70.01.69.0 and updatesnear-workspaces
. An update of bothrust-version
andnear-workspaces
is required to make tests build and pass again, hence this PR combines both.Why
1.70.01.69.0The latest version of
near-workspaces
requires at least Rust 1.69.0.BREAKING CHANGES
The minimum supported Rust version is increased from 1.64.0 to
1.70.01.69.0.near-workspaces
near-plugins
should not be affected by this update since it is adev-dependency
only used in tests.workspaces
tonear-workspaces
and many lines in the diff are due to this change.near-sdk
Updating from
4.1.0
to4.1.1
since Near dependencies are already touched in this PR.Outlook
Some other dependencies had major versions bumps and we should update them as well. It might require some refactors, so I would suggest to that in separate PR(s). I will open a tracking issue shortly.