Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings compiling solidity contracts #491

Closed
3 of 5 tasks
mfornet opened this issue Feb 10, 2021 · 2 comments · Fixed by #564
Closed
3 of 5 tasks

Warnings compiling solidity contracts #491

mfornet opened this issue Feb 10, 2021 · 2 comments · Fixed by #564
Labels

Comments

@mfornet
Copy link
Contributor

mfornet commented Feb 10, 2021

Compilation of solidity contracts emits several warnings. To see this locally use:

cd contracts/eth/nearbridge
./dist.sh

Warnings

 Warning: Accessing non-existent property 'INVALID_ALT_NUMBER' of module exports inside circular dependency
  • No License on solidity code triggers warning. Consider using this approach (Only keep one License rather than removing all of them).
dist/Borsh.full.sol: Warning: SPDX license identifier not provided in source file. Before publishing, consider adding a comment containing "SPDX-License-Identifier: <SPDX-License>" to each source file. Use "SPDX-License-Identifier: UNLICENSED" for non-open-source code. Please see https://spdx.org for more information.
dist/NearBridge.full.sol:529:17: Warning: Only state variables can have a docstring. This will be disallowed in 0.7.0.
        bytes32 epoch_id;           /// Epoch start hash of this block's epoch. Used for retrieving validator information
                ^------^
  • Warning: Function state mutability can be restricted to pure
dist/NearDecoder.full.sol:464:5: Warning: Function state mutability can be restricted to pure
    function decodeInitialValidators(Borsh.Data memory data) internal view returns(InitialValidators memory validators) {
    ^ (Relevant source part starts here and spans across multiple lines).
@KaiserKarel
Copy link

I can check this out this weekend.

@mfornet
Copy link
Contributor Author

mfornet commented Apr 16, 2021

Some warnings solved on #553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants