Remove compiled Ethereum contracts from version control and switch to using artifact files #564
Conversation
abacabadabacaba
force-pushed
the
remove-generated-eth-contracts
branch
2 times, most recently
from
2721bda
to
42d35a8
Compare
… using artifact files
abacabadabacaba
force-pushed
the
remove-generated-eth-contracts
branch
from
42d35a8
to
707db3f
Compare
| ) | ||
| let abi, bytecode | ||
| if (ethContractArtifactPath) { | ||
| ({ abi, bytecode } = JSON.parse(fs.readFileSync(ethContractArtifactPath))) |
There was a problem hiding this comment.
Are externals parenthesis required here?
There was a problem hiding this comment.
Yes, see here.
|
One problem I see with current approach is that it is easier to mess up the right contract to use during deployments and interaction. Because it is possible to have different version on the contract and on the repository at the same time. For properly solving #541 we should publish instead these contracts in this repository github release page, and download it from there. |
|
I think there is a more general problem. Suppose that we change the API for relayers, and modify the relayers' code accordingly. Now, if someone is using the new relayer code to interact with the old contract (or vise versa), it will break with some confusing error messages. So, just publishing the contracts is not the full solution, we need to add some check to make sure that the contracts the relayers are interacting with are compatible with the relayers' version. |
… using artifact files (#564)
Fixes #491, #555.
Partial fix for #541.