Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI #489

Merged
merged 11 commits into from
Feb 16, 2021
Merged

fix: CI #489

merged 11 commits into from
Feb 16, 2021

Conversation

mfornet
Copy link
Contributor

@mfornet mfornet commented Feb 9, 2021

Run all implemented tests on CI (tests from other repositories after merging into monorepo were not being executed)

Test plan

  • All tests that were running before merging into monorepo should be executed
  • All tests are passing (CI is green)

@abacabadabacaba
Copy link
Contributor

I think that it is better to submit unrelated changes as separate pull requests.

@mfornet mfornet changed the title fix: Typos on SPEC fix: CI Feb 10, 2021
@mfornet
Copy link
Contributor Author

mfornet commented Feb 10, 2021

I think that it is better to submit unrelated changes as separate pull requests.

@abacabadabacaba Sure, the main purpose of this PR was fixing the CI. And just started by fixing some typos to trigger current CI. Still I see that I made several changes unrelated to fixing CI, so will split them in several PR

@mfornet
Copy link
Contributor Author

mfornet commented Feb 12, 2021

Fixes #459

@mfornet mfornet mentioned this pull request Feb 12, 2021
@mfornet mfornet merged commit 7bd5544 into master Feb 16, 2021
@mfornet mfornet deleted the fix_ci branch April 7, 2021 12:45
karim-en pushed a commit that referenced this pull request Dec 20, 2021
* fix: Export nearup

* fix: CI

* stop ws server

* feat: Allow running nodes in archival mode

* Update pipelines

* Use near nodes in archival mode to avoid gc

* fix: Compile contracts in Mac using docker

* Update build solidity scripts to work in mac

* update yarn.lock

* Use docker-compose for deterministic compilation

* fix(near-proofs): Fix test that verify near proofs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants