fix: Don't use env::signer_account_id #524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use env::predecessor_account_id. Using signer_account_id has the same problems of using tx.origin in Ethereum. See link below for more details: ethereum/solidity#683
This was referenced Mar 11, 2021
abacabadabacaba
suggested changes
Mar 14, 2021
| macro_rules! impl_admin_controlled { | ||
| ($contract: ident, $paused: ident) => { | ||
| use admin_controlled::{AdminControlled as AdminControlledInner, Mask as MaskInner}; | ||
| use near_sdk as near_sdk_inner; |
There was a problem hiding this comment.
Using use in macros is not a very good idea, because it silently imports names into the surrounding namespace. Also, it assumes that near_sdk and admin_controlled crates are present in the list of dependencies of the current crate under their original names.
A more robust solution would be to not use use and to use fully qualifying names starting with $crate (because $crate is the only top-level name such that you know for sure what it refers to).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use env::predecessor_account_id. Using signer_account_id
has the same problems of using tx.origin in Ethereum. See link
below for more details:
ethereum/solidity#683