fix: Withdraw function is now payable #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,6 +52,7 @@ impl BridgeToken { | |||
| self.token.mint(account_id, amount.into()); | |||
| } | |||
|
|
|||
| #[payable] | |||
There was a problem hiding this comment.
Should we return back the deposit? We don't need it to keep it
This is necessary so that users need to sign all withdraw transactions. This change requires an update on the frontend side. Test Plan ========= CI pass
mfornet
force-pushed
the
withdraw_as_payable
branch
from
067a81c
to
9c87191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary so that users need to sign all
withdraw transactions.
This change requires an update on the frontend side.
Fixes: aurora-is-near/rainbow-bridge-frontend#106
Fixes: #28
Test Plan
CI pass