Added support for non-ASCII characters (UNIX/Linux) #95
Conversation
|
Also, this pr should solve #94 . Please advise if you think there are more necessary changes need to be made. Thank you 😃 |
|
@uruha-komachin could you please add some test too? |
There is a [known bug](https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67224) in GCC 9's UTF-8 support, therefore we exclude non-ASCII example and test on GCC 9.
Config with `-DMAGIC_ENUM_OPT_ENABLE_NONASCII=OFF` to disable non-ASCII support. (default on)
|
Hi, I've added an option, However, as there is a known bug in GCC 9's UTF-8 support, we will skip the non-ASCII example and test for GCC version below 10.0. As for Windows, the codepage thingy and unicode support on Windows is a PAIN. Therefore I didn't port this feature to Windows and decided to stop there. This feature will need some future help (of course, if anyone wants to implement this). |
uruha-komachin
changed the title
|
Sorry, I saw the workflow failed, and it was me forgetting to skip the non-ASCII test in |
|
@uruha-komachin I had the nerve to tweak the style a bit. If everything is ok, I'm ready to merge |
|
@Neargye Everything looks great to me. Please feel free to merge this pr 🎉 |
Non-ASCII characters are allowed in C++ identifiers so I added support for them.
tbh, I have to admit that we barely see anyone write code with non-ASCII identifiers. Nevertheless, they're still legal C++ code and they compiles. IMO we should add support for this case.