[WIP] Allow asynchronous operations to depend on each other #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewDryga
changed the title
AndrewDryga
commented
Nov 29, 2017
lib/sage/executor/planner.ex
Outdated
| raise Sage.ExecutorPlannerError, dependency_on_itself_message(name) | ||
| end | ||
|
|
||
| if dep not in reachable_stage_names do |
There was a problem hiding this comment.
Function body is nested too deep (max depth is 2, was 3).
AndrewDryga
force-pushed
the
features/async-after
branch
from
b0221f6 to
cd66dba
Compare
|
I've decided to don't attack this feature because it's against the goal of being a simple tool. We can get back to it later if we have more use cases that needs this (and contributor who can port all executor features to a new async executor). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6