This repository has been archived by the owner on Dec 3, 2018. It is now read-only.
Add translation warning bar #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The green and the red clash a bit, perhaps use a different color for the link? Otherwise, seems to be working well on the staging branch. |
and enable it on /about/milestones/ for fr, ru, zh-hant, zh-hans
VoidingWarranties
force-pushed
the
translation-warning
branch
from
2d106cd
to
63cf8fc
Compare
|
Oh yes, that definitely clashes. Fixed. Also changed the wording slightly to reduce the length. |
|
@DavidVorick can you purge Cloudflare's cache? Only necessary for the staging site if there are separate caches. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and enable it on
/about/milestones/for fr, ru, zh-hant, zh-hansThis PR is live on https://staging.sia.tech/fr/about/milestones (note the bar may not appear red until the CloudFlare cash is purged)