Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a swan svg emoji 🦢 #142

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

add a swan svg emoji 🦢 #142

wants to merge 36 commits into from

Conversation

Necktschnagge
Copy link
Owner

@Necktschnagge Necktschnagge commented Mar 1, 2024 •
edited
Loading

TODOs:

Notes:

Necktschnagge and others added 25 commits February 20, 2024 19:06
@Necktschnagge
original swan
3303f8e
@Necktschnagge
tidy up swan and prototype layouting for the whole SVG
6bf7791
@r0ost3r
Update swan.svg
a832273 
convert to all-relative path
@r0ost3r
Update swan.svg
75bf07c 
convert to all-absolute path
@r0ost3r
Update swan.svg
1e854b2 
tidy svg
@r0ost3r
Update swan.svg
9c795a3 
tidy all-absolute path
@Necktschnagge
fix line 1
20ec927
@Necktschnagge
revert swan svg
7eaf8b3
@Necktschnagge
fix the first path
2795eb8
@Necktschnagge
replace second path
c43e38e
@Necktschnagge
swan border path
c2ce008
@Necktschnagge
neck and feather
433a688
@Necktschnagge
Merge pull request #139 from Necktschnagge/fix-fix-swan
9c6c093 
fix the fix of the swan (just to view diff)
@Necktschnagge
check indent
6872f70
@Necktschnagge
Merge pull request #140 from Necktschnagge/fix-indentation
eaa3e2c 
fix indent
@Necktschnagge
use swan body line as border for filled area
2393186
@Necktschnagge
use neck line, note: neck line had been drawn in reverse direction, n…
eb49f9b 
…eeded to turn coordinate order
@Necktschnagge
remove some unnecessary part
ed2cc4f
@Necktschnagge
rounding the missing parts
d22d870
@Necktschnagge
adjust the beak
18b11cd
@Necktschnagge
review
92d8e8a
@Necktschnagge
reverse the swan neck line without any changes in the curves
cb29b09
@Necktschnagge
Merge 9c6c093: use absolute coordinates for all swan paths
c3373e6
@Necktschnagge
enhancement of ugly indentation
5bf629f 
Merge remote-tracking branch 'origin/fix-swan-svg-enhancement' into swan-base
@Necktschnagge
adjust the colored body to the swans borders,
dd8c1df 
adjust the beak
Merge remote-tracking branch 'origin/fix-swan-body-to-lines' into swan-base
@Necktschnagge Necktschnagge self-assigned this Mar 1, 2024
@Necktschnagge Necktschnagge mentioned this pull request Mar 1, 2024
Open
@Necktschnagge
Copy link
Owner Author

Necktschnagge commented Sep 2, 2024 •
edited
Loading

problem:

our SVG middle-end creates valid SVG including swans
(At least I think so)

Edge can render these SVGs.
Qt cannot.

Did not try other browsers / viewers.

Where to get Qt SVG renderer debug output?
Can we just step-modify the SVG to see when Qt again understands our swans to find the cause of this?

please create another branch for solving the issue and create a PR into swan-base

@Necktschnagge
Copy link
Owner Author

I'll consider moving the Developer feature show SVG into a separate feature branch and merging into main

@Necktschnagge Necktschnagge added this to the 1.y New Features milestone Sep 2, 2024
@Necktschnagge
Copy link
Owner Author

check

@Necktschnagge
Copy link
Owner Author

https://doc.qt.io/qt-6/qtsvg-module.html

@r0ost3r
Copy link
Collaborator

r0ost3r commented Nov 16, 2024

https://github.com/svgpp/svgpp
https://github.com/sammycage/lunasvg
https://wxsvg.sourceforge.io/
https://github.com/memononen/nanosvg
https://github.com/cppfw/svgren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Necktschnagge Necktschnagge

@r0ost3r r0ost3r

Labels
GUI SVG
Projects
None yet
Milestone
1.y New Features
Development

Successfully merging this pull request may close these issues.
2 participants
@Necktschnagge @r0ost3r