byte-tree-map for distance explorer #180
Conversation
dev-doxyfile for private members
…ture-byte-tree-map-for-solver -s ours
|
See dependency diagram here: 1f335ce94552bed79e277307fdd72c9eb04f9b04.pdf |
|
See dependency diagram here: c85f4cb6fe0558ca1f2e41a00e6ee1e87712a758.pdf |
|
See dependency diagram here: 43448c6ee04430fa02bd94377b6b8ee2aca7a72e.pdf |
|
See dependency diagram here: 5f7bc4975642a458d7ab3407d8c8feeecf39973c.pdf |
|
|
||
| private: | ||
|
|
||
| using target_distance_map_type = std::map<cell_id_type, size_type>; | ||
| //using target_distance_map_type = std::map<cell_id_type, size_type>; |
There was a problem hiding this comment.
There should be an option to use std::map for performance comparison
There was a problem hiding this comment.
The review hint is correct but does not match the line.
We should offer std::map instead of byte_tree_map.
| * If entirely explored, and the farest found state is at depth x, then must contain an entry (x+1, {empty vector}). | ||
| * It means depth x has been explored, leafs of x+1 are empty. | ||
| */ | ||
| unexplored_map _unexplored_by_depth; // use this to replace _unexplored_leafs and also _max_exploration_depth #### note that the other variant might be better as long as we do not use true A* algorithm here. |
There was a problem hiding this comment.
Decide for a final decision here using map or single vector + depth variable
|
See dependency diagram here: d72528189bf3a42c80a9e8c332e45a3770b92581.pdf |
|
|
||
| size_type _state_count_threshold{ 0 }; | ||
| size_type _max_depth{ 0 }; | ||
| using distance_int = uint8_t; |
There was a problem hiding this comment.
Check usage and size_t conversions!
| * @details Explores the state space according to \p policy | ||
| * @details Clears \p destination first anyway. | ||
| Explores the state space according to \p policy. | ||
| Leaves \p destination empty and returns immediately if exploration did not find \p target_cell. | ||
| */ | ||
| template<class State_Label_T> | ||
| void get_simple_bigraph( |
There was a problem hiding this comment.
review this function again / for the first time!
|
See dependency diagram here: 426c8039e056810ce145d74a99c659cc0324eb08.pdf |
|
See dependency diagram here: 1b10bf138cf7a03830d8143899189990bc264a03.pdf |
Byte tree map for distance explorer
Dependencies:
Summary
Changes
New Features
Fixes
TODOs
prettiness_evaluator.hWe typedef many sub types there. Maybe some of them could be template arguments to make features more flexible. Check this.Follow-up Actions
class prettiness_evaluatoruses graph structure that can be optimized. It uses key values for referencing successors and requires seraching for key values in iterating contexts. affects the graph itsel afaik and the annotationsclass prettiness_evaluatorhas some feature requests at its end: SeeTODOs in code.Knowledge:
further ideas