-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructuring suggestions #74
Conversation
on/ off switch for solver @Necktschnagge -> #100 |
may be we should use |
Color ball looks nice in code @r0ost3r. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things you can implement @r0ost3r
src/mainwindow.h
Outdated
QLabel* stepsKey; | ||
QLabel* stepsValue; | ||
|
||
// add more labels: "BoardId:" "702563:378 // 3:0:2:3:5:2:7 " hint: redPlanetQuadrant, .., .., .., permutation, board rotation, target cell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the requested additional QLabels here,
you may also add your color ball here.
I'd also be fine with just a Label with empty space and the correct color.
Feel free to find your favourite solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r0ost3r Can you add the labels as requested in these comments?
void MainWindow::StatusbarItems::init(QStatusBar* statusbar) { | ||
stepsKey = new QLabel(statusbar); // parent takes ownership | ||
stepsValue = new QLabel(statusbar); // parent takes ownership | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you'd have to add the initialisation code for additional labels or other widgets inside status bar.
I don't want a toggle switch. Furthermore, solver will have more modes than just ON and OFF. -> #100 |
No, let's stick to addPermanentWidget. That's not so nice. |
Let's code the rest together @r0ost3r |
I changed some things, made some experiments.
Let's discuss this and apply some further enhancements before merging into your branch.