Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructuring suggestions #74

Merged
merged 9 commits into from
Jan 29, 2024

Conversation

Necktschnagge
Copy link
Owner

I changed some things, made some experiments.
Let's discuss this and apply some further enhancements before merging into your branch.

@r0ost3r
Copy link
Collaborator

r0ost3r commented Dec 20, 2023

on/ off switch for solver @Necktschnagge
https://stackoverflow.com/questions/14780517/toggle-switch-in-qt
no need to place solver in status bar

-> #100

@r0ost3r
Copy link
Collaborator

r0ost3r commented Dec 20, 2023

may be we should use QStatusBar::insertWidget or QStatusBar::addWidget for Color instead of PermanentWidget @Necktschnagge

@Necktschnagge
Copy link
Owner Author

Color ball looks nice in code @r0ost3r.
Can you add it to the status bar?

Copy link
Owner Author

@Necktschnagge Necktschnagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things you can implement @r0ost3r

src/mainwindow.h Outdated
QLabel* stepsKey;
QLabel* stepsValue;

// add more labels: "BoardId:" "702563:378 // 3:0:2:3:5:2:7 " hint: redPlanetQuadrant, .., .., .., permutation, board rotation, target cell
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the requested additional QLabels here,
you may also add your color ball here.
I'd also be fine with just a Label with empty space and the correct color.
Feel free to find your favourite solution.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r0ost3r Can you add the labels as requested in these comments?

void MainWindow::StatusbarItems::init(QStatusBar* statusbar) {
stepsKey = new QLabel(statusbar); // parent takes ownership
stepsValue = new QLabel(statusbar); // parent takes ownership

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you'd have to add the initialisation code for additional labels or other widgets inside status bar.

@Necktschnagge
Copy link
Owner Author

Necktschnagge commented Dec 26, 2023

on/ off switch for solver @Necktschnagge https://stackoverflow.com/questions/14780517/toggle-switch-in-qt no need to place solver in status bar

I don't want a toggle switch. Furthermore, solver will have more modes than just ON and OFF.

-> #100

@Necktschnagge
Copy link
Owner Author

may be we should use QStatusBar::insertWidget or QStatusBar::addWidget for Color instead of PermanentWidget @Necktschnagge

No, let's stick to addPermanentWidget.
The other methods are intended to add labels that can be obscured by temporary messages.

That's not so nice.
Once we have too many labels we can start thinking about which of them are less important than others.

@Necktschnagge Necktschnagge added the important Resolve this with priority label Jan 6, 2024
@Necktschnagge
Copy link
Owner Author

Let's code the rest together @r0ost3r

This was referenced Jan 15, 2024
@Necktschnagge Necktschnagge merged commit 6e6c3da into feature-status-bar Jan 29, 2024
12 checks passed
@Necktschnagge Necktschnagge deleted the fix-statusbar-restructure branch January 29, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Resolve this with priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants