[Issue#38] Setup eslint config for the project Closes #38,#37 #49

madhuni · 2020-07-07T02:02:52Z

In this PR

I have set up the eslint config for the project and added some basic rules ko make sure the code follows industry standards and best practices. Below are the key changes done as part of this PR:

I have fixed the linting errors in all the existing components.
For many of the components, .js was used as the file extension and we were using .css for some components and .scss for some components. I have made sure that all the files which includes jsx syntax, are renamed with .jsx extension and all the .css files are renamed as .scss.
I have also made sure that the file name of the .scss the file is pascalCase e.g. SimpleButton.scss and not simpleButton.scss. For the upcoming PR's we should make sure that the component files are being generated via plop templates using the gen:c script so that these issues won't happen.
I have also added the pre-commit and pre-push hooks. This is going to make sure that the code is properly formatted and linted before the user is allowed to make any commit or push to the remote repository.

I have extended Airbnb's eslin-config so that we follow the standards suggested and used by the top tech giants.

madhuni · 2020-07-07T02:06:14Z

@NehemiahK, @Krishnamoorthy12, @caleb335 since we are having a couple of open PRs, let's make sure that this PR is reviewed and merged first so that the other contributors can take a pull from master and install the linting rules and fix them to avoid any of linting or formatting errors in the existing PR(s).

Note: Please remember to Squash and Merge the PR to keep the commit history clean in the master branch.

kaf-lamed-beyt · 2020-07-07T06:18:42Z

Awesome work @madhuni 🙌 I like the way you documented your PR.

BTW @NehemiahK I'm thinking we should have a way to communicate with the people who are contributing to this repository of some changes that would be or are necessary for development, for example, a case like this now, we'd have explained to them the new updates to the repository and how they can go about contributing effectively.

What do you guys think

NehemiahK · 2020-07-07T06:30:36Z

@caleb335 what did you have in mind? Also Thanks @madhuni this seems awesome

madhuni · 2020-07-07T07:09:45Z

Thanks @caleb335, @NehemiahK.

BTW @NehemiahK I'm thinking we should have a way to communicate with the people who are contributing to this repository of some changes that would be or are necessary for development, for example, a case like this now, we'd have explained to them the new updates to the repository and how they can go about contributing effectively.
What do you guys think

Regarding this, I think that's a good point @caleb335. I also feel the need to communicate different things but every time creating a new issue doesn't make sense.

What about having a discord server for our project? We can have all the contributors in one place, and we can share all the updates as announcements. Also, we can have multiple channels to talk about different things. WDYT?

NehemiahK · 2020-07-07T07:21:57Z

The issue is I think there are generally two types of contributors. Those who are very active and will read updates/etc if it's on Discord or Github. But, the majority of contributors are one-time contributors, so they will be unlikely to join a Discord for example

madhuni · 2020-07-07T07:40:07Z

Your point is valid. I have two points for that:

1- We have to make sure the contribution guide is up to date and additionally we can add some automated tasks in our workflow which will make sure that any PR or an issue is following the standards or not.

2- Having a separate discord server will not cause any harm to us. At least the active contributors will have a common place to discuss things on how to take things further in the future. We will know each other as well and if other contributors want, they can also keep in touch with the team.

Let me know your thoughts.

NehemiahK · 2020-07-07T07:50:59Z

Makes sense.

I agree the CI/CD you mentioned could be really useful.
No issue with the Discord server as long as we are aware most people contributing will not be using it.

kaf-lamed-beyt · 2020-07-07T09:07:31Z

Your point is valid. I have two points for that:

1- We have to make sure the contribution guide is up to date and additionally we can add some automated tasks in our workflow which will make sure that any PR or an issue is following the standards or not.

2- Having a separate discord server will not cause any harm to us. At least the active contributors will have a common place to discuss things on how to take things further in the future. We will know each other as well and if other contributors want, they can also keep in touch with the team.

Let me know your thoughts.

This is ok, automating the process would make us informed of some certain changes.

So what aspects are we tracking...

"When issues are submitted or when PRs are submitted to be merged"?

kaf-lamed-beyt · 2020-07-07T09:08:29Z

@caleb335 what did you have in mind? Also Thanks @madhuni this seems awesome

Let's go with @madhuni idea

madhuni · 2020-07-07T09:34:19Z

So what aspects are tracking...

"When issues are submitted or when PRs are submitted to be merged"?

We will include both of them. We will provide a certain template for the contributors to follow while raising a PR or creating a new issue. I will take this up as part of #50. @NehemiahK can you please assign this issue to me?

Also, I have one question, @NehemiahK what are the parameters to fulfill in order to get access to merge the PR(s) and assigning issues. I am frequently reviewing the PR so sometimes feels if I can get permission to merge the PR(s). Just wanted to quickly check on this. I would like to be one of the maintainers of the project if that's fine with you.

ashispavan · 2020-07-14T22:12:44Z

@NehemiahK , @madhuni , @caleb335 I have taken the liberty to create a Discord server. Please feel free to join:

https://discord.gg/CGT8TCx

@NehemiahK I agree to your point that one-time contributors won't be using it. Nevertheless, we could use it for this and for any other open-source projects or discussions. I believe it would be a good place to find and share other projects that we can contribute/learn.

kaf-lamed-beyt · 2020-07-15T22:21:50Z

Nice work 👍

…

On Tue, Jul 14, 2020 at 11:13 PM Ashis Pavan ***@***.***> wrote: @NehemiahK <https://github.com/NehemiahK> , @madhuni <https://github.com/madhuni> , @caleb335 <https://github.com/Caleb335> I have taken the liberty to create a Discord server. Please feel free to join: https://discord.gg/CGT8TCx @NehemiahK <https://github.com/NehemiahK> I agree to your point that one-time contributors won't be using it. Nevertheless, we could use it for this and for any other open-source projects or discussions. I believe it would be a good place to find and share other projects that we can contribute/learn. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALPFZWRGXQQM3LYWI6XJO3TR3TJ6XANCNFSM4OSKS2VA> .

Kanishka Mohan Madhuni and others added 22 commits July 2, 2020 21:15

chore: add eslint setup

affa9f8

I have extended Airbnb's eslin-config so that we follow the standards suggested and used by the top tech giants.

fix: change the file type .jsx and .scss

5b8dda7

fix(Avatar.jsx): linting errors

7e4c6c6

fix(ComponentList): linting

d9acf34

fix(Heading): linting errors

afab874

fix(InfiniteScroll): linting error

fd3cec9

fix(Navbar): linting errors

e2713a8

fix(RadioButton): linting errors

e2639bf

fix(SimpleButton): linting errors

5dd5536

fix(Tabs): linting errors

a76fade

fix(AvatarDemo): linting errors

d3f29cc

fix(HeadingDemo): linting errors

ea5ce52

fix(InfiniteScrollDemo): linting errors

86177d8

fix(ProgressBarDemo): linting errors

86f6198

fix(SimpleButtonDemo): linting errors

c5a6749

fix(TabsDemo): linting errors

0652688

fix: import error

80a9d96

fix(serviceWorker): linting errors

a4467e5

fix: further disable eslint rule

50b9745

chore: add parsing option for eslint config

487250c

fix(DemoDisplay): linting errors

c027a87

new: add pre-commit and pre-push hooks

e778a7d

madhuni mentioned this pull request Jul 7, 2020

[FIX] demo layout issue fixed. progress bar added in to demo list #43

Open

krissh-codes merged commit 226cce6 into NehemiahK:master Jul 7, 2020

This was referenced Jul 7, 2020

Add pre-commit and pre-push hooks #37

Closed

Restructure README.md file to contain more contribution details #40

Open

madhuni deleted the issue#38_eslint-setup branch July 7, 2020 07:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Issue#38] Setup eslint config for the project Closes #38,#37 #49

[Issue#38] Setup eslint config for the project Closes #38,#37 #49

Uh oh!

madhuni commented Jul 7, 2020 •

edited

Loading

Uh oh!

madhuni commented Jul 7, 2020 •

edited

Loading

Uh oh!

kaf-lamed-beyt commented Jul 7, 2020

Uh oh!

NehemiahK commented Jul 7, 2020

Uh oh!

madhuni commented Jul 7, 2020

Uh oh!

NehemiahK commented Jul 7, 2020

Uh oh!

madhuni commented Jul 7, 2020 •

edited

Loading

Uh oh!

NehemiahK commented Jul 7, 2020

Uh oh!

kaf-lamed-beyt commented Jul 7, 2020 •

edited

Loading

Uh oh!

kaf-lamed-beyt commented Jul 7, 2020

Uh oh!

madhuni commented Jul 7, 2020 •

edited

Loading

Uh oh!

ashispavan commented Jul 14, 2020

Uh oh!

kaf-lamed-beyt commented Jul 15, 2020 via email

Uh oh!

Uh oh!

[Issue#38] Setup eslint config for the project Closes #38,#37 #49

[Issue#38] Setup eslint config for the project Closes #38,#37 #49

Uh oh!

Conversation

madhuni commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In this PR

Uh oh!

madhuni commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaf-lamed-beyt commented Jul 7, 2020

Uh oh!

NehemiahK commented Jul 7, 2020

Uh oh!

madhuni commented Jul 7, 2020

Uh oh!

NehemiahK commented Jul 7, 2020

Uh oh!

madhuni commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NehemiahK commented Jul 7, 2020

Uh oh!

kaf-lamed-beyt commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kaf-lamed-beyt commented Jul 7, 2020

Uh oh!

madhuni commented Jul 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashispavan commented Jul 14, 2020

Uh oh!

kaf-lamed-beyt commented Jul 15, 2020 via email

Uh oh!

Uh oh!

madhuni commented Jul 7, 2020 •

edited

Loading

madhuni commented Jul 7, 2020 •

edited

Loading

madhuni commented Jul 7, 2020 •

edited

Loading

kaf-lamed-beyt commented Jul 7, 2020 •

edited

Loading

madhuni commented Jul 7, 2020 •

edited

Loading