Merge pull request brave#13850 from ryanml/no-dialogue-after-recovery

Fixes wallet recovery dialogue re-appearing on relaunch after a successful recovery.

js/about/preferences.js

@@ -519,6 +519,7 @@ class AboutPreferences extends React.Component {
       ledgerRecoveryOverlayVisible: false
     })
     this.forceUpdate()
+    this.removeParams()
   }
 
   enableSyncRestore (enabled) {
@@ -548,6 +549,16 @@ class AboutPreferences extends React.Component {
     this.setState(newState)
   }
 
+  /**
+   * Using the history API, this removes any parameters
+   * from the current URL, leaving only the needed hash (ex #payments)
+   * This does not reload the page, it only modifies the browser history state,
+   * which replaces what is entered in the address bar
+   */
+  removeParams () {
+    window.history.replaceState(null, null, `#${this.hash}`)
+  }
+
   /**
    * Parses a query string like:
    * about:preferences#payments?ledgerBackupOverlayVisible
@@ -632,9 +643,12 @@ class AboutPreferences extends React.Component {
     let stateDiff = {}
     stateDiff[`${overlayName}OverlayVisible`] = isVisible
     this.setState(stateDiff)
-    // Tell ledger when Add Funds overlay is closed
-    if (isVisible === false && overlayName === 'addFunds') {
-      appActions.onAddFundsClosed()
+    if (isVisible === false) {
+      // Tell ledger when Add Funds overlay is closed
+      if (overlayName === 'addFunds') {
+        appActions.onAddFundsClosed()
+      }
+      this.removeParams()
     }
   }