Imporves perf of bookmark hanger

Resolves brave#9674 Auditors: @bsclifton Test Plan: - have a lot of bookmarks (1k +) - try to add a bookmark with clicking on the star
NejcZdovc · Jul 5, 2017 · 765c713 · 765c713
1 parent 0562bf4
commit 765c713
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/app/renderer/components/bookmarks/addEditBookmarkHanger.js b/app/renderer/components/bookmarks/addEditBookmarkHanger.js
@@ -185,7 +185,7 @@ class AddEditBookmarkHanger extends React.Component {
     props.currentDetail = currentDetail // TODO (nejc) improve, primitives only
     props.originalDetail = originalDetail // TODO (nejc) improve, primitives only
     props.destinationDetail = bookmarkDetail.get('destinationDetail') // TODO (nejc) improve, primitives only
-    props.hasBookmarks = state.get('sites').find(
+    props.hasBookmarks = state.get('sites').some(
       (site) => siteUtil.isBookmark(site) || siteUtil.isFolder(site)
     )
 

diff --git a/js/state/siteUtil.js b/js/state/siteUtil.js
@@ -753,11 +753,17 @@ module.exports.getFolder = function (sites, folderId) {
 module.exports.getFolders = function (sites, folderId, parentId, labelPrefix) {
   parentId = parentId || 0
   let folders = []
-  sites.toList().sort(module.exports.siteSort).forEach((site) => {
-    if ((site.get('parentFolderId') || 0) === parentId && module.exports.isFolder(site)) {
+  sites
+    .filter(site => {
+      return (site.get('parentFolderId', 0) === parentId && module.exports.isFolder(site))
+    })
+    .toList()
+    .sort(module.exports.siteSort)
+    .forEach((site) => {
       if (site.get('folderId') === folderId) {
         return
       }
+
       const label = (labelPrefix || '') + (site.get('customTitle') || site.get('title'))
       folders.push({
         folderId: site.get('folderId'),
@@ -766,8 +772,7 @@ module.exports.getFolders = function (sites, folderId, parentId, labelPrefix) {
       })
       const subsites = module.exports.getFolders(sites, folderId, site.get('folderId'), (label || '') + ' / ')
       folders = folders.concat(subsites)
-    }
-  })
+    })
   return folders
 }